Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36844 - Fail early when syncing non-library repos #10778

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

sjha4
Copy link
Member

@sjha4 sjha4 commented Oct 25, 2023

What are the changes introduced in this pull request?

Fail properly when trying to sync non-library repos

Considerations taken when implementing this change?

What are the testing steps for this pull request?

  1. Create a repository. (Note repo_id)
  2. Add it to some CV and publish.
  3. Fetch either the archived or the cv-env version repo from console. Katello::Repository.where(library_instance_id: repo_id).first
  4. Try to sync the repo from step 3 using hammer: hammer repository sync --id=env_repo_id

@chris1984 chris1984 self-assigned this Oct 31, 2023
Copy link
Member

@chris1984 chris1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, code looks fine and works well:

[vagrant@hammer ~]$ hammer repository sync --id=9
Could not synchronize the repository:
  attempted to sync a non-library repository.

@sjha4 sjha4 merged commit 2831bae into Katello:master Nov 1, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants