-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #36828 - add host products report jail methods #10769
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
force-pushed
the
36828-sca-jail
branch
from
October 13, 2023 20:14
514af31
to
b82414d
Compare
Also adds a new method to list host installed products with IDs |
jeremylenz
reviewed
Oct 18, 2023
@@ -587,7 +587,7 @@ class ::Host::Managed::Jail < Safemode::Jail | |||
:host_collections, :pools, :hypervisor_host, :installed_debs, | |||
:installed_packages, :traces_helpers, :advisory_ids, :package_names_for_job_template, | |||
:filtered_entitlement_quantity_consumed, :bound_repositories, | |||
:single_content_view, :single_lifecycle_environment | |||
:single_content_view, :single_lifecycle_environment, :purpose_role_status_label, :purpose_usage_status_label |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ianballou
force-pushed
the
36828-sca-jail
branch
from
October 18, 2023 21:16
b82414d
to
4d38ad7
Compare
ianballou
force-pushed
the
36828-sca-jail
branch
from
October 20, 2023 15:03
4d38ad7
to
a4c08d2
Compare
jeremylenz
approved these changes
Oct 20, 2023
[test katello] |
1 similar comment
[test katello] |
I think we're gonna have to wait for #10774 to be merged ;) |
ianballou
force-pushed
the
36828-sca-jail
branch
from
October 24, 2023 16:48
a4c08d2
to
f946a94
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Adds some jail methods for theforeman/foreman#9863
Considerations taken when implementing this change?
These should be perfectly safe methods.
What are the testing steps for this pull request?
Test out theforeman/foreman#9863 with this PR.