Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #38127 - Add hammer host bootc images sub-commamd #980

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Fixes #38127 - Add hammer host bootc images sub-commamd #980

merged 1 commit into from
Jan 17, 2025
+40 −0

Conversation

lfu
Copy link
Member

@lfu lfu commented Jan 10, 2025 •
edited
Loading

Requires Katello/katello#11277.

New command hammer host bootc images

@lfu lfu force-pushed the host_bootc_images_30347 branch from 127f9df to 3db1839 Compare January 13, 2025 19:39
@lfu lfu mentioned this pull request Jan 15, 2025
Merged
@lfu
Copy link
Member Author

lfu commented Jan 15, 2025 

-------------------------------------|-------------------------------------------------------------------------|-----------
BOOTC RUNNING IMAGE                  | BOOTC RUNNING IMAGE DIGEST                                              | HOST COUNT
-------------------------------------|-------------------------------------------------------------------------|-----------
quay.io/centos-bootc/centos-bootc:42 | sha256:18ec8a272258b22bf9707b1963d72b8987110c8965c3d08b496fac0b1fb22159 | 3         
-------------------------------------|-------------------------------------------------------------------------|-----------

ianballou
ianballou reviewed Jan 16, 2025
View reviewed changes
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well! Just one wording suggestion:

lib/hammer_cli_katello/host_bootc.rb Outdated
Comment on lines 11 to 12
field :bootc_booted_image, _("Bootc running image")
field :bootc_booted_digest, _("Bootc running image digest")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
field :bootc_booted_image, _("Bootc running image")
field :bootc_booted_digest, _("Bootc running image digest")
field :bootc_booted_image, _("Running image")
field :bootc_booted_digest, _("Running image digest")

To align with f96ac21#diff-46014eb7623d50b912d0ff35a3c09161a3d59ea36da6425c611b3582ce9b0de7

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@lfu lfu force-pushed the host_bootc_images_30347 branch from 3db1839 to f1f5935 Compare January 16, 2025 20:26
ianballou
ianballou approved these changes Jan 17, 2025
View reviewed changes
Copy link
Member

@ianballou ianballou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@lfu lfu merged commit 83ae9db into Katello:main Jan 17, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianballou ianballou ianballou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfu @ianballou