Refs #37151 - Fix --force flag to use option_override_name #979
+23
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#977 should have validated
option_override_name
, but inadvertently looked atoption_value
instead. This causedhammer content-override
to break completely.Turns out our Hammer tests were also wrong. Params should be like
but instead were like
To test:
--override-name
flag, valuestrue
,false
,0
, and1
(and really, any value) should work.--override-name
ofenabled
, the values above should also work.--override-name
of anything other thanenabled
, you should get the (new & improved) error