Fixes #38019 - Add hammer support for flatpak remotes and remote repositories #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjha4
force-pushed
the
flatpak_hammer
branch
5 times, most recently
from
9d23163 to
d560b36
Compare
sjha4
changed the title
|
Test failures are due to rubocop autocorrect on my last push..Will push.. |
ianballou
reviewed
Dec 5, 2024
There was a problem hiding this comment.
It seems there are missing organization options for deleting remotes:
Usage:
hammer flatpak-remote <delete|destroy> [OPTIONS]
Options:
--id NUMBER Flatpak remote id
--name VALUE Flatpak remote name to search by
-h, --help Print help
[vagrant@centos7-hammer-devel hammer-cli-katello]$ hammer flatpak-remote delete --name "Fedora flatpak"
Could not delete the Flatpak Remote.:
Error: Missing options to search organization.
[vagrant@centos7-hammer-devel hammer-cli-katello]$ hammer flatpak-remote delete --name "Fedora flatpak" --organization-id 1
Could not delete the Flatpak Remote.:
Error: Unrecognised option '--organization-id'.
ianballou
reviewed
Dec 5, 2024
There was a problem hiding this comment.
The help text for creating remotes is a little confusing, specifically for the URLs:
Usage:
hammer flatpak-remote create [OPTIONS]
Options:
--description VALUE Description of the flatpak remote
--name VALUE Name
--organization[-id|-title|-label] VALUE/NUMBER Organization name/title/label/id
--registry-url VALUE Optional Registry url. Will be updated when remote is scanned.
--token VALUE Token/password for the flatpak remote
--url VALUE Url
--username VALUE Username for the flatpak remote
-h, --help Print help
It isn't quite clear what the difference is between the url and the registry-url. It also isn't clear why someone would need to enter a registry-url.
|
Besides my comments above, the general workflows seem to be working well 👍 |
sjha4
force-pushed
the
flatpak_hammer
branch
2 times, most recently
from
34bf5cc to
980bb2b
Compare
|
Updated to address reviews. 👍🏼 |
ianballou
reviewed
Dec 6, 2024
| end | ||
| end | ||
|
|
||
| class MirrorCommand < HammerCLIKatello::SingleResourceCommand |
There was a problem hiding this comment.
Perhaps unrelated to this PR, but do you know what "organization title" is?
We typically only have ID / Name / Label...
Usage:
hammer flatpak-remote remote-repository mirror [OPTIONS]
Options:
--async Do not wait for the task
--flatpak-remote[-id] VALUE/NUMBER Name/Id of associated flatpak remote
--id NUMBER Flatpak remote repository id
--name VALUE Name to search by
--organization[-id|-title|-label] VALUE/NUMBER Name/Title/Label/Id of associated organization
--product[-id] VALUE/NUMBER Product name/id to mirror the remote repository to
-h, --help Print help
There was a problem hiding this comment.
[2] pry(main)> org.title
=> "Default Organization"
[3] pry(main)> org.name
=> "Default Organization"
[4] pry(main)> org.label
=> "Default_Organization"
Title seems to be the same as name.
sjha4
force-pushed
the
flatpak_hammer
branch
2 times, most recently
from
0cf5a73 to
2c53124
Compare
|
Merging.. 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds hammer support for flatpak remotes. The sub-commands added are list/show/create/update/delete and scan.
This also supports list/info on remote repository and adds a command to mirror remote repository into katello.
This requires Katello/katello#11223 for testing..
Working on more tests but the commands should be ready for testing.