Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parsing support for gift transactions (Schwab Equity Awards JSON). #539

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

m01
Copy link
Contributor

@m01 m01 commented Jun 30, 2024

This adds a new action type, as TRANSFER seems to deal with money transfers rather than share transfers, and SALEs also involve money whereas gifted shares do not.

The calculation code will raise a NotImplementedError if it encounters one of these transactions.

This may help #510. This contribution has been developed in my spare time.

cgt_calc/parsers/schwab_equity_award_json.py Outdated Show resolved Hide resolved
cgt_calc/main.py Show resolved Hide resolved
@vmartinv
Copy link
Collaborator

vmartinv commented Jul 2, 2024

If adding proper handling for gifts is out of the table, I think a better fix would be to raise an unknown transaction error in the parser if clarity is your concern. I see no need to add parsing for an unsupported transaction.
If a new contributor decides to implement gifts for a different parser they will have to worry about them working with Schwab which adds more work.

This adds a new action type, as TRANSFER seems to deal with money transfers
rather than share transfers, and SALEs also involve money whereas gifted
shares do not.

The calculation code will raise a NotImplementedError if it encounters
one of these transactions.

This may help KapJI#510. This contribution has been developed in my spare time.
@m01
Copy link
Contributor Author

m01 commented Jul 6, 2024

If adding proper handling for gifts is out of the table,

It's not off the table - I plan to look into it but I don't really want to promise that I'll end up implementing it either at this stage.

If a new contributor decides to implement gifts for a different parser they will have to worry about them working with Schwab which adds more work.

I thought this would help progress support for gifts by one step, but also I don't mind if you want to hold off merging this until there's code using it for more than just error handling.

@m01
Copy link
Contributor Author

m01 commented Dec 14, 2024

So #549 adds support for a TRANSFER_TO_SPOUSE action type.

This PR and #549 could be linked up (and based on local testing it seems to work). The question is, how should gift transactions be identified as being to a spouse (as other types of gift may be taxed differently)? The data export doesn't contain enough data to determine that.

Possible approaches I've thought about:

  • Assume all gift transactions are transfers to a spouse, possibly only if some flag is supplied.
  • Depend on some extra data somewhere (maybe in a simple CSV file) that identifies transfer to spouse transactions.

I'm not sure what the best approach is for this project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants