Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(EIP_Generator): Sorting root properties and definitions properties for EIPs #1961

Conversation

shivamG640
Copy link
Contributor

@shivamG640 shivamG640 commented Jan 29, 2025

part of: #1939

@shivamG640 shivamG640 force-pushed the feat/EIP_Generator_Sort branch 2 times, most recently from 4065c46 to 505c1d7 Compare January 29, 2025 12:48
@shivamG640 shivamG640 marked this pull request as ready for review January 29, 2025 12:50
@shivamG640 shivamG640 requested a review from lordrip January 29, 2025 12:51
Copy link
Member

@lordrip lordrip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please let's restore the test and we're good to go

@@ -116,7 +113,7 @@ void shouldFillGroupInformationForModelName() {
}

@Test
void shouldFillGroupInformationForMode() {
void shouldFillGroupInformationForModel() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this catch

@shivamG640 shivamG640 force-pushed the feat/EIP_Generator_Sort branch from 505c1d7 to c188abb Compare January 29, 2025 14:20
@shivamG640 shivamG640 requested a review from lordrip January 29, 2025 14:25
@lordrip lordrip merged commit b9a42de into KaotoIO:feat/form-with-anyof-support Jan 29, 2025
4 of 8 checks passed
@shivamG640 shivamG640 deleted the feat/EIP_Generator_Sort branch January 29, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants