Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text size in config panel has been decreased #1945

Open
apupier opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1939
Open

Text size in config panel has been decreased #1945

apupier opened this issue Jan 24, 2025 · 2 comments · May be fixed by #1939
Assignees
Labels
bug Something isn't working
Milestone

Comments

@apupier
Copy link
Member

apupier commented Jan 24, 2025

Describe the Bug

The new text size for the attribute names in the config panel is a bit smaller after upgrade to Patternfly 6 (and requires me to come closer to screen). Given all the blank space still available, I think we shoudl set back the text to previous size.

Steps to Reproduce the Bug or Issue

  1. Open config panel

Screenshots or Videos

Image

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: 2.5.0-dev Git commit hash
    102da40
@apupier apupier added the bug Something isn't working label Jan 24, 2025
@lordrip lordrip added the on hold Issues or pull requests that are waiting for something label Feb 4, 2025
@lordrip
Copy link
Member

lordrip commented Feb 4, 2025

Let's ask the patternfly team before overriding the text size

@lordrip lordrip linked a pull request Feb 5, 2025 that will close this issue
34 tasks
@lordrip lordrip moved this from New to In Progress in Kanban Board Feb 5, 2025
@lordrip lordrip added this to the 2.5.0 milestone Feb 5, 2025
@lordrip lordrip removed the on hold Issues or pull requests that are waiting for something label Feb 5, 2025
@lordrip
Copy link
Member

lordrip commented Feb 5, 2025

There's a CSS variable that we can tweak to increase the text size without being invasive to the remaining styles.

  &__label {
    --pf-v6-c-form__label--FontSize: --pf-t--global--font--size--body--md;
    --pf-v6-c-form__label-required--FontSize: --pf-t--global--font--size--body--lg;
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants