Merge pull request #12 from Kaligo/bug/set-cache-expiry

Set 1 day expiration time for idempotent response
Kaligo · Feb 4, 2025 · c7aa848 · c7aa848
2 parents b77520b + dd70dc5
commit c7aa848
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,9 @@
 ## [Change Log]
 
+## [0.1.5] - 2025-02-04
+
+- Set correct expiration time for idempotency cache
+
 ## [0.1.4] - 2025-01-14
 
 - Support metrics logging via StatsdListener
@@ -19,4 +23,3 @@
 ## [0.1.0] - 2024-11-13
 
 - Initial release
-
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    idempotency (0.1.4)
+    idempotency (0.1.5)
       base64
       dry-configurable
       dry-monitor

diff --git a/lib/idempotency/cache.rb b/lib/idempotency/cache.rb
@@ -43,7 +43,7 @@ def set(fingerprint, response_status, response_headers, response_body)
       key = response_cache_key(fingerprint)
 
       with_redis do |r|
-        r.set(key, serialize(response_status, response_headers, response_body))
+        r.set(key, serialize(response_status, response_headers, response_body), ex: DEFAULT_CACHE_EXPIRY)
       end
     end
 

diff --git a/lib/idempotency/version.rb b/lib/idempotency/version.rb
@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class Idempotency
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end
diff --git a/spec/idempotency/cache_spec.rb b/spec/idempotency/cache_spec.rb
@@ -46,8 +46,9 @@
     let(:response_headers) { { 'header' => 'valuee' } }
 
     it 'sets data in cache correctly' do
-      is_expected.to eq('OK')
+      expect(subject).to eq('OK')
       expect(cache.get(fingerprint)).to eq([response_status, response_body, response_headers])
+      expect(mock_redis.ttl("idempotency:cached_response:#{fingerprint}")).to eq(86_400)
     end
   end