Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to avoid issue with stringi installation #94

Merged
merged 6 commits into from
May 18, 2024
Merged

Conversation

hsonne
Copy link
Member

@hsonne hsonne commented May 5, 2024

Hm, the issue is already reported here: gagolews/stringi#508

This change is Reviewable

Finally, I replaced all stringr function calls by function calls to base R functions or functions from kwb.utils.

@hsonne hsonne changed the title Try to avoid issue with stringi installation from source Try to avoid issue with stringi installation May 5, 2024
testuser added 3 commits May 18, 2024 07:52
instead, use:
- the basic string manipulation functions
- kwb.utils::extractSubstring()
- basename(), dirname()

add helper function:
- email_kwb()

In the vignette, simply use ``` for text
blocks that do not represent R code but
console outputs
@hsonne hsonne merged commit 9f3ddac into dev May 18, 2024
6 checks passed
@hsonne hsonne deleted the fix/stringi-dependency branch May 18, 2024 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant