* **FIX**: Fix major bug in FloatCurve handling that was causing Test…

…FlightFailure_IgnitionFail and TestFlightReliability_EngineCycle to both not apply proper failure chances
KSP-RO · Apr 2, 2016 · 1f62c35 · 1f62c35
1 parent 9b10e11
commit 1f62c35
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 10 deletions.
diff --git a/GameData/TestFlight/Plugins/TestFlight.dll b/GameData/TestFlight/Plugins/TestFlight.dll
diff --git a/GameData/TestFlight/Plugins/TestFlightAPI.dll b/GameData/TestFlight/Plugins/TestFlightAPI.dll
diff --git a/GameData/TestFlight/Plugins/TestFlightContracts.dll b/GameData/TestFlight/Plugins/TestFlightContracts.dll
diff --git a/GameData/TestFlight/Plugins/TestFlightCore.dll b/GameData/TestFlight/Plugins/TestFlightCore.dll
diff --git a/TestFlightFailure_IgnitionFail.cs b/TestFlightFailure_IgnitionFail.cs
@@ -105,6 +105,11 @@ public override void OnUpdate()
                         if (multiplier <= 0f)
                             multiplier = 1f;
 
+                        float minValue, maxValue = -1f;
+                        baseIgnitionChance.FindMinMaxValue(out minValue, out maxValue);
+                        Log(String.Format("TestFlightFailure_IgnitionFail: IgnitionChance Curve, Min Value {0:F2}:{1:F6}, Max Value {2:F2}:{3:F6}", baseIgnitionChance.minTime, minValue, baseIgnitionChance.maxTime, maxValue));
+
+
                         if (this.vessel.situation != Vessel.Situations.PRELAUNCH)
                             ignitionChance = ignitionChance * multiplier * ignitionUseMultiplier.Evaluate(numIgnitions);
 
@@ -174,12 +179,21 @@ public void RestoreIgnitor()
         public override void OnAwake()
         {
             base.OnAwake();
-            baseIgnitionChance = new FloatCurve();
-            baseIgnitionChance.Add(0f, 1f);
-            pressureCurve = new FloatCurve();
-            pressureCurve.Add(0f, 1f);
-            ignitionUseMultiplier = new FloatCurve();
-            ignitionUseMultiplier.Add(0f, 1f);
+            if (baseIgnitionChance == null)
+            {
+                baseIgnitionChance = new FloatCurve();
+                baseIgnitionChance.Add(0f, 1f);
+            }
+            if (pressureCurve == null)
+            {
+                pressureCurve = new FloatCurve();
+                pressureCurve.Add(0f, 1f);
+            }
+            if (ignitionUseMultiplier == null)
+            {
+                ignitionUseMultiplier = new FloatCurve();
+                ignitionUseMultiplier.Add(0f, 1f);
+            }
         }
     }
 }

diff --git a/TestFlightReliability_EngineCycle.cs b/TestFlightReliability_EngineCycle.cs
@@ -108,10 +108,16 @@ public override string GetInfo()
         public override void OnAwake()
         {
             base.OnAwake();
-            thrustModifier = new FloatCurve();
-            thrustModifier.Add(0f, 1f);
-            cycle = new FloatCurve();
-            cycle.Add(0f, 1f);
+            if (thrustModifier == null)
+            {
+                thrustModifier = new FloatCurve();
+                thrustModifier.Add(0f, 1f);
+            }
+            if (cycle == null)
+            {
+                cycle = new FloatCurve();
+                cycle.Add(0f, 1f);
+            }
         }
 
         public override List<string> GetTestFlightInfo()