Remove max level requirements on tracking station for skopos contracts #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2489
There already exists a spot in RP-1 where this is done with the Astronaut Complex for the First EVA contract, where minLevel is specified but maxLevel is not:
RP-1/GameData/RP-1/Contracts/Earth Crewed Adv/FirstEVA.cfg
Lines 61 to 68 in 3be415a
The contract configurator code also seems to be correctly set up to handle this situation:
https://github.com/KSP-RO/ContractConfigurator/blob/2d4ee9c189da88dc2edf08fd44b8ec6ac26fec1c/source/ContractConfigurator/Requirement/FacilityRequirement.cs#L63-L65
requirementmet is true if (((no minlevel) or (level ge minlevel)) and ((no maxlevel) or (level le maxlevel)))This should be better for future proofing.