Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Orbital maneuvers #64

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

akrasuski1
Copy link
Contributor

Library containing most common orbital maneuvers - currently lacks interplanetary transfers, I never was good at them.

If you wonder why all tests are prefixed with "om" - it's short for orbital maneuvers.
…s/test_lib_orbital_maneuvers.ks

Should we have a different folder for every libraries' unit tests? I think only if there are many files.
I hoped someone more educated in steering will do this, but seeing that not many people commit anything to KSLib, I decided to publish my version of exec_node function.
parameter nd.

local mth is MaxShipThrust().
lock burntime to nd:deltav:mag/(mth/mass).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. if maximum thrust is 0 (e.g. the player forgot to activate engines or the stage burned out) it will crash with cryptic error message

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If I understand it right this formula is not perfect: it doesn't account for the fact that the ship mass decreases in the process.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I think this PR should contain just the orbital library - the exec_node is not really finished and I included it here just because I noticed there was none in KSLib. But really, as it stands now, exec_node's quality is likely too far below quality to be included.

@space-is-hard
Copy link
Member

@akrasuski1 Was there anything else you had planned for this, or is it ready to merge?

@akrasuski1
Copy link
Contributor Author

I guess it's ok to merge.
On Jul 18, 2015 2:15 PM, "space-is-hard" notifications@github.com wrote:

@akrasuski1 https://github.com/akrasuski1 Was there anything else you
had planned for this, or is it ready to merge?


Reply to this email directly or view it on GitHub
#64 (comment).

@space-is-hard
Copy link
Member

This still needs a documentation page. @akrasuski1 are you up to writing one?

@@ -0,0 +1,259 @@
@lazyglobal off.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs // This file is distributed under the terms of the MIT license, (c) the KSLib team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants