-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orbital maneuvers #64
base: master
Are you sure you want to change the base?
Conversation
If you wonder why all tests are prefixed with "om" - it's short for orbital maneuvers.
…s/test_lib_orbital_maneuvers.ks Should we have a different folder for every libraries' unit tests? I think only if there are many files.
I hoped someone more educated in steering will do this, but seeing that not many people commit anything to KSLib, I decided to publish my version of exec_node function.
parameter nd. | ||
|
||
local mth is MaxShipThrust(). | ||
lock burntime to nd:deltav:mag/(mth/mass). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- if maximum thrust is 0 (e.g. the player forgot to activate engines or the stage burned out) it will crash with cryptic error message
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- If I understand it right this formula is not perfect: it doesn't account for the fact that the ship mass decreases in the process.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I think this PR should contain just the orbital library - the exec_node is not really finished and I included it here just because I noticed there was none in KSLib. But really, as it stands now, exec_node's quality is likely too far below quality to be included.
Added disclaimer about its limited functionability.
@akrasuski1 Was there anything else you had planned for this, or is it ready to merge? |
I guess it's ok to merge.
|
This still needs a documentation page. @akrasuski1 are you up to writing one? |
@@ -0,0 +1,259 @@ | |||
@lazyglobal off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs // This file is distributed under the terms of the MIT license, (c) the KSLib team
Library containing most common orbital maneuvers - currently lacks interplanetary transfers, I never was good at them.