Fix cloning instances with shared stock files on Windows #4297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HebaruSan
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you clone an instance and use the shared stock files option from #4129, and then clone the clone again, the resulting final instance's junction symlink entries are invalid.
Cause
The target path can end up with a prefix of
\??\\??\, which is one\??\too many.(Do not ask me wtf that sequence means. I have now read about five explanations of it and still have not the slightest clue. It's just Windows being Windows.)
Changes
Now when
DirectoryLink.TryGetTargetretrieves the target of a junction on Windows, it strips\??\prefixes from it. This way whenReparseDataBuffer.FromPathadds it again, there'll be only one.Fixes #4296.