Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude dependencies in the changeset from supported by list #4261

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

HebaruSan
Copy link
Member

Problem

If you install BoringCrewServices, KSPCommunityPartModules will be listed as a dependency in the changeset, but also as optional in the "Supported By" list. It doesn't make sense for it to be in both places.

Reported by @SofieBrink and @AlexSkylark in Discord.

Causes

  • BoringCrewServices depends on KSPCommunityPartModules, which adds the latter to the changeset as a dependency
  • KSPCommunityPartModules supports BoringCrewServices, which adds the former to the "Supported By" list
  • The relationship resolver currently excludes only the mods that you directly selected from the "Supported By" list, not their dependencies (probably because this relationship structure doesn't actually make sense)

Changes

Now ModuleInstaller.FindRecommendations passes recommenders to RelationshipResolver.Supporters instead of toInstall. This will exclude dependencies of the selected mods from the "Supported By" list.

@HebaruSan HebaruSan added Bug Something is not working as intended Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Relationships Issues affecting depends, recommends, etc. labels Nov 21, 2024
@HebaruSan HebaruSan merged commit b3ecbda into KSP-CKAN:master Nov 21, 2024
3 checks passed
@HebaruSan HebaruSan deleted the fix/depends-supports branch November 21, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Relationships Issues affecting depends, recommends, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant