Exclude dependencies in the changeset from supported by list #4261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you install
BoringCrewServices
,KSPCommunityPartModules
will be listed as a dependency in the changeset, but also as optional in the "Supported By" list. It doesn't make sense for it to be in both places.Reported by @SofieBrink and @AlexSkylark in Discord.
Causes
BoringCrewServices
depends onKSPCommunityPartModules
, which adds the latter to the changeset as a dependencyKSPCommunityPartModules
supportsBoringCrewServices
, which adds the former to the "Supported By" listChanges
Now
ModuleInstaller.FindRecommendations
passesrecommenders
toRelationshipResolver.Supporters
instead oftoInstall
. This will exclude dependencies of the selected mods from the "Supported By" list.