Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
Cause
ActiveControl
, which doesn't always work (details unclear, but possibly related to the search control containing sub-controls?)ManageMods.ProcessCmdKey
, which is only called when that control has focusChanges
.Focus()
is used to set the focusManageMods
back toMain
so it can be globalManageMods
implements a newISearchableControl
interface to advertise its ability to respond to Ctrl+F keystroke, whichMain
then uses to find a control.Any()
are replaced by checking.Count
insteadAfter this, Ctrl+F sets the focus to the search box whenever it's visible, and if other controls (Edit Modpack, Unmanaged Files, etc.) add their own search tools in the future, they can implement
ISearchableControl
.