Proportional, granular progress updates for installing #4055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
Fixes #4014.
Side fixes
ModuleInstaller.onReportModInstalled
is now a properevent
, and its type isAction<CkanModule>
instead of a custom delegateModuleInstaller.InstallModule
formerly returnedIEnumerable<string>
, which isn't a great idea for a collection that's going to be passed to other functions becauseIEnumerable<>
often involves lazy evaluation, which may cause performance problems if evaluated multiple times. Now it's aList<string>
.ModuleInstaller.ksp
is renamed toinstance