Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger progress updates for frozen downloads #4052

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

HebaruSan
Copy link
Member

Motivation

Sometimes CKAN is able to connect to a host, but the download times out without sending any data (it seems like SpaceDock does this every few weeks). Since our system for progress updates depends on traffic received, this means that no progress updates are sent. And since these progress updates drive the progress bars on the progress tab, and since they are ignored unless 3 seconds have already passed since the download group started, I'm pretty sure it's possible for such a frozen download to never show up as an empty progress bar.

Changes

  • Now a frozen download will trigger progress updates every 5 seconds, even if no data is coming through. This will ensure that progress bars will appear for such downloads in the progress tab, so the user can see what's happening.
  • A couple of stray folders that I found in my working copy are added to the .gitignore for convenience

@HebaruSan HebaruSan added Enhancement New features or functionality Easy This is easy to fix Core (ckan.dll) Issues affecting the core part of CKAN Network Issues affecting internet connections of CKAN labels Mar 6, 2024
@HebaruSan HebaruSan merged commit 55fb0ba into KSP-CKAN:master Mar 6, 2024
8 checks passed
@HebaruSan HebaruSan deleted the fix/idle-network branch March 6, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Easy This is easy to fix Enhancement New features or functionality Network Issues affecting internet connections of CKAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant