Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support inline sink patterns #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support inline sink patterns #7

wants to merge 1 commit into from

Conversation

mattkdab
Copy link
Member

Change-Id: I3da32c5b7cc7f00fea29c612b0b5e5a8a2fa5881

@dantti
Copy link
Member

dantti commented May 24, 2024

CI is fixed, but would need to rebase to get a green

@mattkdab
Support inline sink patterns
9e9ac67 
Change-Id: I3da32c5b7cc7f00fea29c612b0b5e5a8a2fa5881
@mattkdab mattkdab force-pushed the mattkdab/sink-patterns branch from c6bbb0a to 9e9ac67 Compare May 24, 2024 15:33
seanharmer
seanharmer approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@seanharmer seanharmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be worth adding a test for inline sink patterns?

@mattkdab
Copy link
Member Author

Might be worth adding a test for inline sink patterns?

yes, this is in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanharmer seanharmer seanharmer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattkdab @dantti @seanharmer