update to new ancestry search params #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Holger Eisold <github@eisold.family>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Carmen,
first of all, thanks for this awesome module... i use it very often...
For the time being i was missing the year dates in the ancestry links...
So it seems we now have a new search url with different params...
I've played with them real quick... even if we construct our url with params that are empty from our side... ancestry will remove them right away...but if the are fille with values... the are used...
the new search params are straight forward and you may notice a pattern here...
so here are my little changes... maybe you find a way to also get the Marrige dates/place and the general Residence working...
Hope this helps also other users...
please let me know what you think...
cheers
/Holger