✨ added shouldGroupStatusCode, close #2

Julien-R44 · Dec 19, 2021 · ff7c224 · ff7c224
1 parent dad0dee
commit ff7c224
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 2 deletions.
diff --git a/src/CollectPerformanceMetrics.ts b/src/CollectPerformanceMetrics.ts
@@ -62,7 +62,12 @@ export class CollectPerformanceMetrics {
      * End HTTP request timer.
      */
     if (httpMetricOptions.enabled && stopHttpRequestTimer) {
-      stopHttpRequestTimer({ statusCode })
+      let statusCodeStr = statusCode.toString()
+      if (httpMetricOptions.shouldGroupStatusCode) {
+        statusCodeStr = statusCodeStr[0] + 'xx'
+      }
+
+      stopHttpRequestTimer({ statusCode: statusCodeStr })
     }
   }
 }
diff --git a/templates/prometheus.txt b/templates/prometheus.txt
@@ -1,4 +1,4 @@
-export default {
+const prometheusConfig {
   /*
   |--------------------------------------------------------------------------
   | Expose prometheus metrics via HTTP endpoint.
@@ -37,6 +37,7 @@ export default {
     name: 'adonis_http_request_durations',
     includeQueryParams: false,
     includeRouteParams: false,
+    shouldGroupStatusCode: true,
     help: 'Total time each HTTP request takes.',
     labelNames: ['method', 'url', 'statusCode'],
     buckets: [0.003, 0.03, 0.1, 0.3, 1.5, 10],
@@ -72,3 +73,5 @@ export default {
     prefix: '',
   },
 }
+
+export default prometheusConfig