Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TimeZones.jl relocatable #479

Merged
merged 21 commits into from
Dec 20, 2024
Merged

Make TimeZones.jl relocatable #479

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
56865ff
Set _COMPILED_DIR during __init__
lcontento Oct 29, 2024
05d4c9e
Add fallback for older versions of TZJData
lcontento Nov 4, 2024
ca1ba7b
Backwards compatibility with hardcoded artifact hashes
lcontento Nov 4, 2024
8879f7e
Merge branch 'master' into lc/relocatable
lcontento Nov 4, 2024
0402582
remove the docs manifest
lcontento Nov 4, 2024
c7612a0
Turn off coverage for the setting of _COMPILED_DIR
lcontento Dec 16, 2024
9af280c
Determine tree hash directly from Artifacts.toml
omus Dec 19, 2024
f448082
Merge branch 'master' into lc/relocatable
omus Dec 20, 2024
3fbda1d
Remove CodeCov exclusion comments
omus Dec 20, 2024
5aa01e6
Use `locate_package`
omus Dec 20, 2024
7e3a3cb
Test for sysimage
omus Dec 20, 2024
63cbb29
fixup! Test for sysimage
omus Dec 20, 2024
c303339
fixup! Test for sysimage
omus Dec 20, 2024
99f9e7e
fixup! Test for sysimage
omus Dec 20, 2024
451d241
fixup! Test for sysimage
omus Dec 20, 2024
3aa1b39
fixup! Test for sysimage
omus Dec 20, 2024
c64babd
fixup! Test for sysimage
omus Dec 20, 2024
b70192c
Validate test failure
omus Dec 20, 2024
73da68a
fixup! Test for sysimage
omus Dec 20, 2024
549fdfd
Back to working
omus Dec 20, 2024
8d430e1
Make job name unique
omus Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/TimeZones.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,16 @@ export TimeZone, @tz_str, istimezone, FixedTimeZone, VariableTimeZone, ZonedDate

_scratch_dir() = @get_scratch!("build")

const _COMPILED_DIR = Ref{String}(TZJData.ARTIFACT_DIR)
const _COMPILED_DIR = Ref{String}()

# TimeZone types used to disambiguate the context of a DateTime
# abstract type UTC <: TimeZone end # Already defined in the Dates stdlib
abstract type Local <: TimeZone end

function __init__()
# Must be set at runtime to ensure relocatability
_COMPILED_DIR[] = TZJData.artifact_dir()
omus marked this conversation as resolved.
Show resolved Hide resolved

# Dates extension needs to happen everytime the module is loaded (issue #24)
init_dates_extension()

Expand Down
Loading