Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fast_substitute on subarrays of symbolic variables #1423

Merged
merged 2 commits into from
Jan 31, 2025

Conversation

AayushSabharwal
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 30, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 8.88%. Comparing base (6202fa4) to head (16df6db).
Report is 79 commits behind head on master.

Files with missing lines Patch % Lines
src/build_function.jl 0.00% 6 Missing ⚠️
src/variable.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master   #1423      +/-   ##
=========================================
+ Coverage    3.95%   8.88%   +4.92%     
=========================================
  Files          51      51              
  Lines        4824    4875      +51     
=========================================
+ Hits          191     433     +242     
+ Misses       4633    4442     -191     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AayushSabharwal AayushSabharwal marked this pull request as draft January 30, 2025 15:52
@AayushSabharwal AayushSabharwal marked this pull request as ready for review January 31, 2025 07:17
@AayushSabharwal AayushSabharwal marked this pull request as draft January 31, 2025 07:18
@AayushSabharwal AayushSabharwal marked this pull request as ready for review January 31, 2025 07:28
@ChrisRackauckas ChrisRackauckas merged commit 024e5a5 into JuliaSymbolics:master Jan 31, 2025
11 of 13 checks passed
@AayushSabharwal AayushSabharwal deleted the as/fix-fastsub branch January 31, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants