-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exposing single precision support from MKL #108
base: master
Are you sure you want to change the base?
Conversation
- Adding check for square matrix - Changing Project.lic to Panua.lic and name of of file form "project_pardiso.jl" to "panua_pardiso.jl"
Tests fail on 1.6 as we compare the against results from SparseArrays which did not support |
I think if we drop testing on 1.6 we also would have to bump the min julia version, most of the ecosystem including LinearSolve.jl is going to 1.10 anyway. OTOH this would be kind of a pity as there is no real reason to in the package code which would require a higher version of 1.6. But I think this is too much sentiment, and we should focus on keeping maintenance simple... |
Keeping tests running for 1.6 by always computing the reference solution using Float64/CompelxF64.
Converting results back to Float32/ComplexF32.
Agree with this. Regarding this PR, should there be a check that the Lines 326 to 329 in a645c66
? |
FWIW the package would still be compatible with older version - it would just be the MKLPardiso tests for Float32/ComplexF32 that would fail. But I agree that it would probably be best for the tests to still run on 1.6. Because of this I've fixed the tests so that they should not fail on 1.6 by computing the reference solution in Float64/ComplexF64 and then converting the results back to Float32/ComplexF32. For some reason a few of the tests for Float32 inputs fail when using MKL_jll v. 2025 (locally the tests seem to run fine using e.g. 2023, 2024 but fail similar to the CI when using 2025). |
…sting that the solution actually works rather than comparing with SparseArrays
… MKLPardisoSolver.
The error was not in the MKL_jll version, but rather that the hermitian positive tests where quite ill-conditioned (I still don't understand why this was only caught on 1.6 - did something change with The current solution is to add a diagonal to the hermitian positive tests. At the same time i've changed the tests so that they check that solution works rather than comparing with the answer from SparseArrays (in the failures yesterday both solutions were actually wrong but the tests failed only because they two solutions where not equal). |
colptr
androwval
when using Panua in order to avoid memory usage in the case of the sparsity pattern not changing.