Allow LazyJLLWrappers for JLLs #571
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BinaryBuilder2 generates JLLs that use `LazyJLLWrappers` instead of `JLLWrappers`, we need to allow that here for them to get registered.
giordano
approved these changes
Jul 28, 2024
DilumAluthge
approved these changes
Jul 28, 2024
|
CI failed, but the failures don't look like my fault? |
|
Confirmed that the failures are not my fault, the same failures occur on a meaningless PR: #572 |
|
The problem is this line: https://github.com/JuliaBinaryWrappers/MozillaCACerts_jll.jl/blob/713bd3679eeb3671788eb5f3c5e5ca064a63cc99/Project.toml#L15 That line is incorrect. It should be |
Someone opened JuliaPackaging/BinaryBuilder.jl#1324 but it's still marked as draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BinaryBuilder2 generates JLLs that use
LazyJLLWrappersinstead ofJLLWrappers, we need to allow that here for them to get registered.