Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Mingw_jll v11.0.0 #111897

Merged

Conversation

JuliaRegistrator
Copy link
Contributor

@JuliaRegistrator JuliaRegistrator commented Jul 27, 2024

Copy link
Contributor

github-actions bot commented Jul 27, 2024

Hello, I am an automated registration bot. I help manage the registration process by checking your registration against a set of AutoMerge guidelines. If all these guidelines are met, this pull request will be merged automatically, completing your registration. It is strongly recommended to follow the guidelines, since otherwise the pull request needs to be manually reviewed and merged by a human.

1. New package registration

Please make sure that you have read the package naming guidelines.

2. AutoMerge Guidelines which are not met ❌

  • Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.
  • JLL packages are only allowed to depend on Pkg, Libdl, Artifacts, JLLWrappers, LazyArtifacts, TOML, MPIPreferences and other JLL packages

3. Needs action: here's what to do next

  1. Please try to update your package to conform to these guidelines. The General registry's README has an FAQ that can help figure out how to do so.
  2. After you have fixed the AutoMerge issues, simply retrigger Registrator, the same way you did in the initial registration. This will automatically update this pull request. You do not need to change the version number in your Project.toml file (unless the AutoMerge issue is that you skipped a version number).

If you need help fixing the AutoMerge issues, or want your pull request to be manually merged instead, please post a comment explaining what you need help with or why you would like this pull request to be manually merged. Then, send a message to the #pkg-registration channel in the public Julia Slack for better visibility.

4. To pause or stop registration

If you want to prevent this pull request from being auto-merged, simply leave a comment. If you want to post a comment without blocking auto-merging, you must include the text [noblock] in your comment.

Tip: You can edit blocking comments to add [noblock] in order to unblock auto-merging.

UUID: 2d94bacf-4d71-535d-a47c-45e808015115
Repo: https://github.com/JuliaBinaryWrappers/Mingw_jll.jl.git
Tree: b65d0889ca6201cedbfbecfacf75c69720531c0a

Registrator tree SHA: 17aec322677d9b81cdd6b9b9236b09a3f1374c6a
@JuliaRegistrator JuliaRegistrator force-pushed the registrator-mingw_jll-2d94bacf-v11.0.0-3f9f0d172b branch from f423d5a to 529c1fc Compare August 5, 2024 18:11
JuliaRegistrator referenced this pull request in JuliaBinaryWrappers/Mingw_jll.jl Aug 5, 2024
@staticfloat
Copy link
Member

Name does not meet all of the following: starts with an upper-case letter, ASCII alphanumerics only, not all letters are upper-case.

Because this is a JLL, the underscore seems to be tripping this rule up. I guess the JLL autodetection fails when the PR comes from julia registrator instead of the Yggdrasil bot.

JLL packages are only allowed to depend on Pkg, Libdl, Artifacts, JLLWrappers, LazyArtifacts, TOML, MPIPreferences and other JLL packages

This JLL build is from BB2, which has a new LazyJLLWrappers. I have a PR open to fix this, but it's bogged down by broken CI at the moment. So I'm going to manually merge this so I can continue to make forward progress on BB2, which needs this registered.

@staticfloat staticfloat merged commit 6f40998 into master Aug 5, 2024
9 of 11 checks passed
@staticfloat staticfloat deleted the registrator-mingw_jll-2d94bacf-v11.0.0-3f9f0d172b branch August 5, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants