Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AtomsBase Unit conversion #27

Open
cortner opened this issue May 24, 2024 · 1 comment
Open

AtomsBase Unit conversion #27

cortner opened this issue May 24, 2024 · 1 comment

Comments

@cortner
Copy link
Member

cortner commented May 24, 2024

The atomsbase interface in THIS LINE strips units without bothering to convert. I suggest to either introduce a check that units are compatible or to convert the cutoff radius to the right unit before applying ustrip
@cortner
Copy link
Member Author

cortner commented May 24, 2024

CC @tjjarvinen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cortner