Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handling complex numbers for PairwisePotential #655
Handling complex numbers for PairwisePotential #655
Changes from 1 commit
8a5bd40
281e161
42b82c0
4198c1c
1b9a3c7
20c8a17
ca7f803
98b65a0
4185299
45da86c
d4d48e9
ef14519
9135a16
3f343ea
0157e80
b4beeee
cbe2980
de7405c
86141e0
aa2bf98
afc7c14
a558373
f88dd86
1d1d790
610d404
284a915
82c3bda
74908cf
0927546
1c3d395
9200787
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These fixes are not for the issue above. Is the fix not already upstream in a released version? If yes, only define the functions if the version is below the one that has the fix (and then at some point we remove the code and depend on a new version)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This JuliaDiff/ForwardDiff.jl#577 seems to fix the exponentiation problem. So maybe remove it altogether?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it fix JuliaDiff/ForwardDiff.jl#514 (comment)? Since my message was after that PR was merge I don't think so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, I thought is was after. This is strange, something seems to have fixed the issue, because I am not running into it anymore, even for this test:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about the code in my comment in the forwarddiff tracker above?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the issue was very specific: when differentiating at a real number in a complex direction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed, didn't test the right thing 🙄.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, the bug was due to something we talked about earlier if the types of
x
andy
differ. Let's keep it that way.