max_stepsize improvements #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #402 +/- ##
=======================================
Coverage 99.77% 99.77%
=======================================
Files 72 72
Lines 7574 7592 +18
=======================================
+ Hits 7557 7575 +18
Misses 17 17 ☔ View full report in Codecov by Sentry. |
kellertuer
reviewed
Jul 24, 2024
kellertuer
reviewed
Jul 24, 2024
mateuszbaran
added
enhancement
Ready-for-Review
kellertuer
approved these changes
Jul 24, 2024
|
Sure, I will update the date in changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been debugging some issues with optimization on Hyperrectangle and noticed it lacks
max_stepsize. Also,WolfePowellLinesearchby default tries callingmax_stepsizewith an invalid point. If it tries to get the global maximum stepsize, it should not provide the point, and if it wants local maximum stepsize (which would make some sense), it should callmax_stepsizebefore each search separately.