Fix decorated objectives and Cache Display #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ay when using caches in the summary.
Codecov Report
@@ Coverage Diff @@
## master #279 +/- ##
==========================================
- Coverage 99.70% 99.64% -0.06%
==========================================
Files 73 73
Lines 6502 6264 -238
==========================================
- Hits 6483 6242 -241
- Misses 19 22 +3
... and 53 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug that appeared when passing a decorated objective, e.g. a Cache, to CPPA.
Along the way I notices that the summary might also be nice for caches, so now the solver run (when returning the objective as well) also reports on how much of each of the caches was used.
This still might need some test coverage.