Make symtriUpper! rely on a QL style algorithm instead of an LQ style algorithm #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasnoack
force-pushed
the
an/fixsymtri
branch
from
882d6fc to
f641292
Compare
andreasnoack
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 91.72% 91.55% -0.17%
==========================================
Files 10 10
Lines 1547 1516 -31
==========================================
- Hits 1419 1388 -31
Misses 128 128 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andreasnoack
force-pushed
the
an/fixsymtri
branch
2 times, most recently
from
f4b5d36 to
54b2790
Compare
…d LQ This allows for working on columns instead of rows of the matrix which is faster. Also, simplify the implementations to rely on exsiting linear algebra routines. This also fixed a bug. Remove the AbstractMatrix sybtyping of EigenQ in alignment with the changes to LinearAlgebra.
andreasnoack
force-pushed
the
an/fixsymtri
branch
from
54b2790 to
5be6778
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for working on columns instead of rows of the matrix which is faster. Also, simplify the implementations to rely on exsiting linear algebra routines. This also fixed a bug.
Remove the AbstractMatrix sybtyping of EigenQ in alignment with the changes to LinearAlgebra.