Skip to content

Commit

Permalink
pass through kwds in l/rmul! (#98)
Browse files Browse the repository at this point in the history
* pass through kwds in l/rmul!

* Update test_muladd.jl
  • Loading branch information
dlfivefifty authored Jul 12, 2022
1 parent ecedd14 commit c20d16d
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ArrayLayouts"
uuid = "4c555306-a7a7-4459-81d9-ec55ddd5c99a"
authors = ["Sheehan Olver <solver@mac.com>"]
version = "0.8.8"
version = "0.8.9"

[deps]
FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
Expand Down
6 changes: 3 additions & 3 deletions src/lmul.jl
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ const BlasMatRmulMat{StyleA,StyleB,T<:BlasFloat} = Rmul{StyleA,StyleB,<:Abstract

axes(M::MatLmulVec) = (axes(M.A,1),)

lmul(A, B) = materialize(Lmul(A, B))
lmul!(A, B) = materialize!(Lmul(A, B))
rmul!(A, B) = materialize!(Rmul(A, B))
lmul(A, B; kwds...) = materialize(Lmul(A, B); kwds...)
lmul!(A, B; kwds...) = materialize!(Lmul(A, B); kwds...)
rmul!(A, B; kwds...) = materialize!(Rmul(A, B); kwds...)

materialize(L::Lmul) = copy(instantiate(L))

Expand Down
1 change: 1 addition & 0 deletions test/test_muladd.jl
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,7 @@ Random.seed!(0)

@test all(mul(UpperTriangular(A),x) .===
copy(Lmul(UpperTriangular(A),x)) .===
ArrayLayouts.lmul(UpperTriangular(A),x) .===
ArrayLayouts.lmul!(UpperTriangular(A),copy(x)) .===
copyto!(similar(x),Lmul(UpperTriangular(A),x)) .===
UpperTriangular(A)*x .===
Expand Down

2 comments on commit c20d16d

@dlfivefifty
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/64125

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.8.9 -m "<description of version>" c20d16d3b82269619eb867898462a86e57cbcbd2
git push origin v0.8.9

Please sign in to comment.