Prune versions not referenced in juliaup.json with --prune-orphans
#1146
+78
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to remove julia folders in the juliaup folder whose path is not referenced in juliaup.json This will typically clean up direct download version that were somehow not removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I took a look at #1129 and it seems like if a direct download channel was deleted and the .juliaup folder was not, it would forever be ignored by the
gccommand. I attempt to address it by adding a--prune-orphansflag similar to the--prune-linkedflag that will remove any folder that starts with "julia-" that is not referenced by the "juliaup.json" config file.Name is definitely open for suggestions, and I'd love suggestions to make my code more idiomatic. At the moment it feels clunky.
If this approach is accepted, I'll write a test.
I also add some clarifying comments to the SystemChannel code to make it easier to understand.