Base: append!, resize!: convert length to Int before passing it on
#57585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsajko
changed the title
Base: append! convert length to Int before passing it onBase: append!: convert length to Int before passing it on
nsajko
changed the title
Base: append!: convert length to Int before passing it onBase: append!, resize!: convert length to Int before passing it on
nsajko
force-pushed
the
Base_arrays_append_vector_typeassert
branch
from
2538b85 to
b2fbf50
Compare
jishnub
approved these changes
Mar 8, 2025
Reduces the number of invalidations from 2061 to 2045 on running this code: ```julia struct I <: Integer end Base.Int(::I) = 7 ``` NB: `_growend!`, which the length gets passed on to, converts to `Int` immediately anyway.
nsajko
force-pushed
the
Base_arrays_append_vector_typeassert
branch
from
b10bfd4 to
fc2d1c6
Compare
|
Reproducer for the invalidation count: ./julia -E 'using SnoopCompileCore; i=(@snoop_invalidations (struct I <: Integer end; Base.Int(::I) = 7)); using SnoopCompile; length(uinvalidated(i))' |
nsajko
added
merge me
KristofferC
removed
the
backport 1.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of invalidations from 512 to 505 on running this code: