update path to Compiler stdlib to a valid one similar to how it is done for other stdlibs #57274
+13
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KristofferC
added
bugfix
KristofferC
changed the title
32 tasks
KristofferC
force-pushed
the
kc/fix_functionloc_Compiler
branch
from
7215684 to
157774c
Compare
KristofferC
commented
Feb 7, 2025
base/methodshow.jl
Outdated
| path = npath == npath′ ? path : npath′ | ||
| end | ||
| if isdefined(@__MODULE__, :Core) && isdefined(Core, :Compiler) | ||
| compiler_folder = dirname(string(methods(Core.Compiler.eval)[1].file)) |
topolarity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #56865. The Compiler "stdlib" resides in a different location so the current logic didn't handle updating it.
The
line to figure out the build path to the compiler feels very ugly. It is also something that is constant so doing it every time is wasteful...