Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary Base. in MPFR #57037

Closed
wants to merge 1 commit into from
Closed

Conversation

oscardssmith
Copy link
Member

nfc. Presumably someone was developing in REPL and forgot to clean it up.

nfc. Presumably someone was testing in REPL and forgot to clean it up.
@@ -176,9 +176,9 @@ struct BigFloatData{Limb}
end

# BigFloat interface
@inline function Base.getproperty(x::BigFloat, s::Symbol)
@inline function etproperty(x::BigFloat, s::Symbol)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@inline function etproperty(x::BigFloat, s::Symbol)
@inline function getproperty(x::BigFloat, s::Symbol)

But actually I think you do need the qualifications for the method extensions, since this is in a module that hasn't imported getproperty.

@ararslan
Copy link
Member

I think the qualifications are necessary:

error during bootstrap:
LoadError("sysimg.jl", 0, LoadError("Base.jl", 0, LoadError("mpfr.jl", 0, UndefVarError(:ScopedValues, Base.MPFR))))

base/mpfr.jl defines the Base.MPFR module that contains all of the definitions here, so the contents are "isolated" from Base in some sense, necessitating the qualification.

@oscardssmith
Copy link
Member Author

never mind then.

@DilumAluthge DilumAluthge deleted the os/mpfr-cleanup branch January 13, 2025 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants