Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip or loosen two errorshow tests on 32-bit Windows #56837

Merged
merged 2 commits into from
Dec 15, 2024
Merged

Skip or loosen two errorshow tests on 32-bit Windows #56837

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1afa684
Skip or loosen two `errorshow` tests on 32-bit Windows
DilumAluthge Dec 14, 2024
e7badda
Add a comment with the issue URL
DilumAluthge Dec 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 16 additions & 2 deletions test/errorshow.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,8 +791,22 @@ backtrace()
@test occursin("g28442", output[3])
@test lstrip(output[5])[1:3] == "[2]"
@test occursin("f28442", output[5])
@test occursin("the above 2 lines are repeated 5000 more times", output[7])
@test lstrip(output[8])[1:7] == "[10003]"
is_windows_32_bit = Sys.iswindows() && (Sys.WORD_SIZE == 32)
if is_windows_32_bit
# These tests are currently broken (intermittently/non-determistically) on 32-bit Windows.
# https://github.com/JuliaLang/julia/issues/55900
# Instead of skipping them entirely, we skip one, and we loosen the other.

# Broken test: @test occursin("the above 2 lines are repeated 5000 more times", output[7])
@test occursin("the above 2 lines are repeated ", output[7])
@test occursin(" more times", output[7])

# Broken test: @test lstrip(output[8])[1:7] == "[10003]"
@test_broken false
else
@test occursin("the above 2 lines are repeated 5000 more times", output[7])
@test lstrip(output[8])[1:7] == "[10003]"
end
end

@testset "Line number correction" begin
Expand Down
Loading