Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type stability of ReadEachIterator #56678

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jakobjpeters
Copy link
Contributor

Its eltype method had an incorrect type declaration. The preexisting tests did not detect this because they check for array equality, where Any[] == Char[] is satisfied.

Before

julia> x = readeach(IOBuffer(), Char);

julia> eltype(x)
Any

julia> collect(x)
Any[]

After

julia> x = readeach(IOBuffer(), Char);

julia> eltype(x)
Char

julia> collect(x)
Char[]

@LilithHafner LilithHafner added the bugfix This change fixes an existing bug label Nov 25, 2024
@fredrikekre
Copy link
Member

Windows failures look real (at least failure in the testset changed by this PR multiple times in a row).

LilithHafner added a commit to LilithHafner/ssh-into-github-runner that referenced this pull request Nov 26, 2024
@inkydragon inkydragon added the io Involving the I/O subsystem: libuv, read, write, etc. label Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug io Involving the I/O subsystem: libuv, read, write, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants