Highlight circular references #56663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The text `"#= circular reference @-$d =#"` is printed yellow. Adds a test with the context `:color => true`.
nsajko
added
display and printing
LilithHafner
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
For most users, circular reference display should be pretty infrequent and when it happens is worth highlighting. This is a subjective judgement call. Based on how people expressed their opinions on slack, my personal preference, and how easy this will be to revert, I'm going to go ahead and merge this so we can try it out.
We can (and should) revert if this gets lots of negative feedback before making it into a release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text
"#= circular reference @-$d =#"is printed yellow. Adds a test with the context:color => true.A straw poll on Slack suggests this is an improvement, with
161823 in favor (including myself) and68 opposed as of the time of writing.Before
After