Skip to content

Commit

Permalink
move forward edges stripping code to correct place (#57197)
Browse files Browse the repository at this point in the history
Fixes a regression in the size of stripped binaries.
  • Loading branch information
JeffBezanson authored Jan 30, 2025
1 parent c172a64 commit 683c5e7
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion src/staticdata.c
Original file line number Diff line number Diff line change
Expand Up @@ -2623,7 +2623,6 @@ static void strip_specializations_(jl_method_instance_t *mi)
if (inferred && inferred != jl_nothing) {
if (jl_options.strip_ir) {
record_field_change((jl_value_t**)&codeinst->inferred, jl_nothing);
record_field_change((jl_value_t**)&codeinst->edges, (jl_value_t*)jl_emptysvec);
}
else if (jl_options.strip_metadata) {
jl_value_t *stripped = strip_codeinfo_meta(mi->def.method, inferred, codeinst);
Expand All @@ -2632,6 +2631,8 @@ static void strip_specializations_(jl_method_instance_t *mi)
}
}
}
if (jl_options.strip_ir)
record_field_change((jl_value_t**)&codeinst->edges, (jl_value_t*)jl_emptysvec);
if (jl_options.strip_metadata)
record_field_change((jl_value_t**)&codeinst->debuginfo, (jl_value_t*)jl_nulldebuginfo);
codeinst = jl_atomic_load_relaxed(&codeinst->next);
Expand Down

1 comment on commit 683c5e7

@nanosoldier
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Executing the daily package evaluation, I will reply here when finished:

@nanosoldier runtests(isdaily = true)

Please sign in to comment.