Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more tests for BinaryBuilder usage #4156

Merged
merged 4 commits into from
Feb 16, 2025
Merged

Add more tests for BinaryBuilder usage #4156

merged 4 commits into from
Feb 16, 2025

Conversation

IanButterworth
Copy link
Member

@IanButterworth IanButterworth commented Feb 15, 2025 •
edited
Loading

Originally the tests added here were

dependencies = [PackageSpec(; name="CMake_jll", version = v"3.24.3")]
Pkg.add(deepcopy(dependencies); platform, julia_version=nothing)

which hit an error, but it turned out to be an incomplete VersionNumber that the Resolver wasn't making clear #4159

Note v"3.24.3+0" exists, but v"3.24.3" doesn't.

@giordano giordano added the binarybuilder Related to the use of Pkg in BinaryBuilder label Feb 15, 2025
@IanButterworth IanButterworth marked this pull request as ready for review February 15, 2025 20:32
@IanButterworth IanButterworth changed the title add more BBB tests Add more tests for BinaryBuilder usage Feb 15, 2025
@IanButterworth IanButterworth mentioned this pull request Feb 15, 2025
Open
@IanButterworth IanButterworth merged commit 92595ec into JuliaLang:master Feb 16, 2025
7 checks passed
@IanButterworth IanButterworth mentioned this pull request Feb 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
binarybuilder Related to the use of Pkg in BinaryBuilder
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IanButterworth @giordano