ca_roots: use files mixing regular and OpenSSL-only certs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #24. PR #18 changed the logic for searching for CA root cert files to skip files containing OpenSSL-only "BEGIN TRUSTED CERTIFICATE" certificates since MbedTLS cannot use these certificates. This was a bit too aggressive: regular certs and OpenSSL-only certs can coexist in the same file, so we should use any file that has some regular cert in it, even if it also has OpenSSL-only certs. We should only emit a warning if we (1) found no files with regular certs and (2) found files with OpenSSL-only certs.
Codecov Report
@@ Coverage Diff @@
## master #25 +/- ##
==========================================
- Coverage 97.63% 96.89% -0.74%
==========================================
Files 4 4
Lines 127 129 +2
==========================================
+ Hits 124 125 +1
- Misses 3 4 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #24. PR #18 changed the logic for searching for CA root cert files to skip files containing OpenSSL-only "BEGIN TRUSTED CERTIFICATE" certificates since MbedTLS cannot use these certificates. This was a bit too aggressive: regular certs and OpenSSL-only certs can coexist in the same file, so we should use any file that has some regular cert in it, even if it also has OpenSSL-only certs. We should only emit a warning if we (1) found no files with regular certs and (2) found files with OpenSSL-only certs.