ssh_known_hosts_file: fix bug with empty list (fix #11) (#13)

We should return an empty file if there are no known hosts files as this will cause no hosts to be considered known, which means we're defaulting secure here.
JuliaLang · Dec 9, 2020 · a251de1 · a251de1 · StefanKarpinski · Dec 9, 2020
1 parent c4a2771
commit a251de1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/ssh_options.jl b/src/ssh_options.jl
@@ -138,7 +138,8 @@ function ssh_known_hosts_file()
     for file in files
         ispath(file) && return file
     end
-    return files[1]
+    return !isempty(files) ? files[1] :
+        isfile("/dev/null") ? "/dev/null" : tempname()
 end
 
 ## helper functions

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -118,6 +118,8 @@ end
         # empty
         ENV["SSH_KNOWN_HOSTS_FILES"] = ""
         @test ssh_known_hosts_files() == []
+        file = ssh_known_hosts_file()
+        @test !isfile(file) || isempty(read(file))
         # explicit default
         ENV["SSH_KNOWN_HOSTS_FILES"] = path_sep
         default = joinpath(homedir(), ".ssh", "known_hosts")