-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update MeshIO for GeometryBasics refactor #97
Conversation
Add support for materials in obj files
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #97 +/- ##
==========================================
- Coverage 77.68% 74.72% -2.97%
==========================================
Files 11 10 -1
Lines 623 736 +113
==========================================
+ Hits 484 550 +66
- Misses 139 186 +47 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
Added the Sponza model from https://casual-effects.com/data/ with only two of the groups/sub-meshes present and all textures removed. That should be enough to test correct loading of group names, "usemtl" tags, |
Oh, true. I didn't have that type at some stages of doing the refactor, so I probably change it then. But I think this is also more in line with other load methods |
obj, ply, stl, msh, off and 2DM use this already |
(I moved the branch to MeshIO for this one)
Changes for JuliaGeometry/GeometryBasics.jl#219
TODO:
Closes #94 (materials, face groups/objects now loaded with obj files)
Fixes #80