Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MeshIO for GeometryBasics refactor #97

Merged
merged 27 commits into from
Nov 19, 2024
Merged

Conversation

ffreyer
Copy link
Collaborator

@ffreyer ffreyer commented Sep 6, 2024

(I moved the branch to MeshIO for this one)

Changes for JuliaGeometry/GeometryBasics.jl#219

TODO:

  • 2dm
  • gts
  • ifs
  • msh
  • obj
  • off
  • ply
  • stl
  • test (locally)

Closes #94 (materials, face groups/objects now loaded with obj files)
Fixes #80

@ffreyer ffreyer closed this Nov 18, 2024
@ffreyer ffreyer reopened this Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 72.24880% with 58 lines in your changes missing coverage. Please review.

Project coverage is 74.72%. Comparing base (9f452ff) to head (8666d91).
Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
src/io/obj.jl 76.28% 46 Missing ⚠️
src/io/ifs.jl 0.00% 6 Missing ⚠️
src/io/gts.jl 0.00% 5 Missing ⚠️
src/io/ply.jl 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #97      +/-   ##
==========================================
- Coverage   77.68%   74.72%   -2.97%     
==========================================
  Files          11       10       -1     
  Lines         623      736     +113     
==========================================
+ Hits          484      550      +66     
- Misses        139      186      +47     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@ffreyer ffreyer marked this pull request as ready for review November 18, 2024 17:46
@ffreyer
Copy link
Collaborator Author

ffreyer commented Nov 18, 2024

Added the Sponza model from https://casual-effects.com/data/ with only two of the groups/sub-meshes present and all textures removed. That should be enough to test correct loading of group names, "usemtl" tags,mesh.views and some mtl file parsing, without excessive bulk.

@SimonDanisch
Copy link
Member

This is a breaking change, that changes the load method:
image

@ffreyer
Copy link
Collaborator Author

ffreyer commented Nov 19, 2024

Oh, true. I didn't have that type at some stages of doing the refactor, so I probably change it then. But I think this is also more in line with other load methods

@ffreyer
Copy link
Collaborator Author

ffreyer commented Nov 19, 2024

obj, ply, stl, msh, off and 2DM use this already

@ffreyer ffreyer merged commit fd17a83 into master Nov 19, 2024
2 of 4 checks passed
@ffreyer ffreyer deleted the ff/GeometryBasics_refactor branch November 19, 2024 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load file with multi meshes Information are lost when mesh has different normals per position
2 participants