Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Macro main #118

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Macro main #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5fac4e8
fix zip syntax
rafaqz Sep 21, 2023
935733f
test macro on Main._DiskArray
rafaqz Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/zip.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,6 @@

Base.zip(::$t, x, xs...) = $_zip_error()
Base.zip(x, ::$t, xs...) = $_zip_error()
Base.zip($t, ::$t, xs...) = $_zip_error()
Base.zip(::$t, ::$t, xs...) = $_zip_error()

Check warning on line 77 in src/zip.jl

View check run for this annotation

Codecov / codecov/patch

src/zip.jl#L77 

Added line #L77 was not covered by tests
end
end
2 changes: 1 addition & 1 deletion test/runtests.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ end
_DiskArray(a; chunksize=size(a)) = _DiskArray(Ref(0), Ref(0), a, chunksize)

# Apply the all in one macro rather than inheriting
DiskArrays.@implement_diskarray _DiskArray
DiskArrays.@implement_diskarray Main._DiskArray

Base.size(a::_DiskArray) = size(a.parent)
DiskArrays.haschunks(::_DiskArray) = DiskArrays.Chunked()
Expand Down
Loading