You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It seems in a lot of cases we call getindex on the parent objects rather than just jumping straight to readblock. If for example we know the type doesn't change we don't always need to allocate another output buffer.
Calling readblock! rather than getindex also has a much lower compilation overhead.
The text was updated successfully, but these errors were encountered:
@meggart what do you think of this as general change in approach?
I was thinking when the type doesn't change we can just use the same allocated memory and skip around all of the getindex machinery completely for the inner arrays, which will make compilation of nested DiskArray broadcasts a lot faster and also reduce runtime allocations.
It seems in a lot of cases we call
getindex
on the parent objects rather than just jumping straight toreadblock
. If for example we know the type doesn't change we don't always need to allocate another output buffer.Calling
readblock!
rather thangetindex
also has a much lower compilation overhead.The text was updated successfully, but these errors were encountered: