Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wherever possible just forward readblock! #187

Open
rafaqz opened this issue Aug 22, 2024 · 2 comments
Open

Wherever possible just forward readblock! #187

rafaqz opened this issue Aug 22, 2024 · 2 comments

Comments

@rafaqz
Copy link
Collaborator

rafaqz commented Aug 22, 2024

It seems in a lot of cases we call getindex on the parent objects rather than just jumping straight to readblock. If for example we know the type doesn't change we don't always need to allocate another output buffer.

Calling readblock! rather than getindex also has a much lower compilation overhead.

@rafaqz
Copy link
Collaborator Author

rafaqz commented Oct 18, 2024

I think we need to define generic readblock on AbstractArray` for this to work generally, it broke a lot of things when I tried it locally.

@rafaqz
Copy link
Collaborator Author

rafaqz commented Nov 12, 2024

@meggart what do you think of this as general change in approach?

I was thinking when the type doesn't change we can just use the same allocated memory and skip around all of the getindex machinery completely for the inner arrays, which will make compilation of nested DiskArray broadcasts a lot faster and also reduce runtime allocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant