Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove length from Stateful Iterators #142

Closed
wkearn opened this issue Jan 31, 2024 · 3 comments
Closed

Remove length from Stateful Iterators #142

wkearn opened this issue Jan 31, 2024 · 3 comments

Comments

@wkearn
Copy link
Contributor

wkearn commented Jan 31, 2024

CI is failing on nightly because of this change: JuliaLang/julia#51747

DiskArrays calls length on a Stateful iterator here:

https://github.com/meggart/DiskArrays.jl/blob/3689544f68f2ac10db8b6f127384df892a1a913f/src/iterator.jl#L40-L60
@wkearn wkearn mentioned this issue Jan 31, 2024
Merged
@felixcremer felixcremer mentioned this issue Feb 1, 2024
Merged
@rafaqz
Copy link
Collaborator

rafaqz commented Feb 1, 2024

Surely this is a breaking change to julia Base?

@rafaqz
Copy link
Collaborator

rafaqz commented Feb 1, 2024

@meggart we may need to define our own DiskStateful iterator and define length on it as in this case we know it is correct.

@felixcremer
Copy link
Contributor

This is closed by #145 .

@wkearn wkearn closed this as completed Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rafaqz @wkearn @felixcremer