some more checks

JuliaIO · Oct 6, 2023 · 4aecd55 · 4aecd55
1 parent cbac1f2
commit 4aecd55
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/src/chunks.jl b/src/chunks.jl
@@ -24,6 +24,8 @@ struct RegularChunks <: ChunkType
     s::Int
     function RegularChunks(cs::Int,offset::Int,s::Int)
         cs>0 || throw(ArgumentError("Chunk sizes must be strictly positive"))
+        -1 < offset < cs || throw(ArgumentError("Offsets must be positive and smaller than the chunk size"))
+        s >= 0 || throw(ArgumentError("Negative dimension lengths are not allowed"))
         new(cs,offset,s)
     end
 end

diff --git a/test/runtests.jl b/test/runtests.jl
@@ -247,6 +247,9 @@ end
     @test_throws BoundsError a2[0]
     @test_throws BoundsError a2[11]
     @test_throws ArgumentError RegularChunks(0,2,10)
+    @test_throws ArgumentError RegularChunks(2,-1,10)
+    @test_throws ArgumentError RegularChunks(2,2,10)
+    @test_throws ArgumentError RegularChunks(5,2,-1)
     b1 = IrregularChunks(; chunksizes=[3, 3, 4, 3, 3])
     @test b1[1] == 1:3
     @test b1[2] == 4:6