Update plot.jl #128
Closed
Update plot.jl #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Proposal to: 1) add a custom line dash style of the edges 2) specify whether to resize the box as a unit square or preserve the proportions (x and y axes) among the different stations
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 33.26% 33.70% +0.43%
==========================================
Files 9 9
Lines 526 534 +8
==========================================
+ Hits 175 180 +5
- Misses 351 354 +3
Continue to review full report at Codecov.
|
|
Is it possible to create two separate PRs for both of these features? While I am on board with the dashed lines (although we might need some changes there), I haven't really thought about non-square plots yet. |
|
Ok, I'll do that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear community,
I propose this pull request that:
What do you think?
Davide