-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I could contribute Marching Tetrahedra on Tetmeshes. #89
Comments
My goal for this package going forward is to remove any high level APIs and just return Effectively this will just export a generic GridVisualize seems like it overlaps here with both Meshing and Contour packages. If we can add functionality only depending on |
Nice to hear this. This IMHO makes quite a lot of sense, and I have chosen this very approach to keep the marching_tetrahedra as generic as possible.
In practice, calculating isosurfaces and calculating cut planes (both are important for visualization) can be done by very much the same code, so "isosurfaces" IMHO would narrow the possible usage.
Ah I only barely noticed Contours.jl. IMHO there are two possible ways to proceed:
After thinking about this more clearly, my gut feeling is a bit in favor of b) How do you see this ? |
So may be we go for b... ? |
I wanted to show some basic ideas before reporting back. I have a WIP branch for the simpler API: https://github.com/JuliaGeometry/Meshing.jl/tree/sjk/mindep1 The tests were written with the GeometryBasics and GeometryTypes API, so it will take some care to re-write them. I realize too this package now has very poor load times, so I would like to investigate that as well. I suspect it is the lookup tables. With that branch the times go from 2.6 to 1.8 seconds or so. Again, the goal here is to just have the |
GridVisualize has small load time (for this purpose I pass the different possible backend packages - GLMakie, PlutoVista etc - as modules to the visualization routines). Let me formulate my goals a bit more precisely. I am thinking most about visualization on simplicial grids. I also tend to think code for all space dimensions together.
Extensions I have in mind
For being able to maintain this efficiently I think all this should go into one package. If it would go here, the focus would become broader than |
Hi, I have this method for extracting plane cuts and isosurfaces from general tetmeshes:
https://github.com/j-fu/GridVisualize.jl/blob/698fb552e250e32a2a5e9a69ff46b0dd28f32db8/src/common.jl#L413
The output can also creates a GeometryBasics.Mesh which can be used with Makie:
https://github.com/j-fu/GridVisualize.jl/blob/698fb552e250e32a2a5e9a69ff46b0dd28f32db8/src/makie.jl#L873
There is also "marching_triangles" for isoline calculation.
In the moment, these are not exported, but they are used by other packages (PlutoVista.jl) or projects (@jlchan). Logically, they should reside outside of GridVisualize.jl, and I have the impression that Meshing.jl could be the right place (though I find the package name a bit misleading...). So before creating another package I would like to discuss to move these into Meshing.jl and export them.
A couple of points:
How do you look at this ?
The text was updated successfully, but these errors were encountered: